Repository navigation
fix(sse): preserve store parameter semantics for openai-compatible responses (#11826) - #11916
Merged
diegosouzapw merged 1 commit intoAug 28, 2026
Conversation
…sponses (diegosouzapw#11826) Codex CLI sends store: false for custom openai-compatible-responses-* backends. stripStore previously deleted the field for any provider that was neither openai nor agentrouter/openai-responses, causing strict Codex-compatible backends to reject the request with "Store must be set to false". Honor the existing openaiStoreEnabled per-connection opt-in: - When enabled, preserve the client-provided store value (or omission). - Otherwise, force body.store = false so stateless backends stay happy. Also export stripInternalBodyFields and call it right before body serialization in BaseExecutor so internal passthrough markers such as _nativeOpenAICompatibleResponsesPassthrough never reach the upstream. Tests cover the matrix for openai-compatible responses, the unchanged openai/agentrouter behavior, and an end-toend DefaultExecutor assertion that no internal markers are serialized upstream. Signed-off-by: Minxi Hou <[EMAIL_REDACTED]>
diegosouzapw
merged commit Aug 28, 2026
6b25981
into
diegosouzapw:release/v3.8.51
7 of 16 checks passed
diegosouzapw
added a commit
that referenced
this pull request
Aug 28, 2026
hammadyasser2010-svg
added a commit
to hammadyasser2010-svg/OmniRoute
that referenced
this pull request
Sep 15, 2026
commit f4c099b Author: Markus Hartung <mail@hartmark.se> Date: Fri Aug 28 16:21:51 2026 -0300 chore(changelog): add missing fragments for diegosouzapw#11919/diegosouzapw#11918/diegosouzapw#11916
HouMinXi
deleted the
fix/11826-strip-store-openai-compatible-responses
branch
September 16, 2026 13:47
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…sponses (diegosouzapw#11826) (diegosouzapw#11916) stripStore() now forces store=false for stateless OpenAI-compatible Responses-API targets unless the connection explicitly opts in via providerSpecificData.openaiStoreEnabled, instead of only handling the openai/agentrouter cases — a client-supplied store value previously passed through untouched to backends that don't actually persist responses server-side. Closes diegosouzapw#11826. Thanks!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ouzapw#11918/diegosouzapw#11916 (diegosouzapw#11938) Adds the 3 missing changelog fragments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11826. Aligns stripStore() contract for openai-compatible Responses targets, preserving client store values when enabled and forcing store=false for stateless Codex backends. Includes TDD test coverage.⚠️ base-red inherited: #11449